Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset locale on login #18023

Merged
merged 4 commits into from
Dec 19, 2021
Merged

Reset locale on login #18023

merged 4 commits into from
Dec 19, 2021

Conversation

zeripath
Copy link
Contributor

Although we reset the locale in a number of places there were several ways of logging in that were missing the same code.

Fix #18020

Signed-off-by: Andrew Thornton [email protected]

Fix go-gitea#18020

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.16.0 milestone Dec 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@f1e8562). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head 893a32c differs from pull request most recent head 740796b. Consider uploading reports for the commit 740796b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18023   +/-   ##
=======================================
  Coverage        ?   45.26%           
=======================================
  Files           ?      821           
  Lines           ?    91287           
  Branches        ?        0           
=======================================
  Hits            ?    41324           
  Misses          ?    43371           
  Partials        ?     6592           
Impacted Files Coverage Δ
routers/web/user/auth.go 11.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e8562...740796b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2021
routers/web/user/auth.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2021
@zeripath
Copy link
Contributor Author

make lgtm work

@zeripath zeripath merged commit 1c7db70 into go-gitea:main Dec 19, 2021
@zeripath zeripath deleted the fix-18020 branch December 19, 2021 13:31
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 19, 2021
Backport go-gitea#18023

Although we reset the locale in a number of places there were several ways of logging in that were missing the same code.

Fix go-gitea#18020

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: Gusted <[email protected]>
@zeripath zeripath added backport/v1.15 backport/done All backports for this PR have been created labels Dec 19, 2021
zeripath added a commit that referenced this pull request Dec 19, 2021
Backport #18023

Although we reset the locale in a number of places there were several ways of logging in that were missing the same code.

Fix #18020

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: Gusted <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 19, 2021
 ## [1.15.8](https://github.com/go-gitea/gitea/releases/tag/v1.15.8) - 2021-12-19

* BUGFIXES
  * Reset locale on login (go-gitea#18023) (go-gitea#18025)
  * Fix reset password email template (go-gitea#17025) (go-gitea#18022)
  * Fix outType on gitea dump (go-gitea#18000) (go-gitea#18016)
  * Ensure complexity, minlength and isPwned are checked on password setting (go-gitea#18005) (go-gitea#18015)
  * Fix rename notification bug (go-gitea#18011)
  * Prevent double decoding of % in url params  (go-gitea#17997) (go-gitea#18001)
  * Prevent hang in git cat-file if the repository is not a valid repository (Partial go-gitea#17991) (go-gitea#17992)
  * Prevent deadlock in create issue (go-gitea#17970) (go-gitea#17982)
* TESTING
  * Use non-expiring key. (go-gitea#17984) (go-gitea#17985)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Dec 19, 2021
lafriks pushed a commit that referenced this pull request Dec 20, 2021
## [1.15.8](https://github.com/go-gitea/gitea/releases/tag/v1.15.8) - 2021-12-19

* BUGFIXES
  * Reset locale on login (#18023) (#18025)
  * Fix reset password email template (#17025) (#18022)
  * Fix outType on gitea dump (#18000) (#18016)
  * Ensure complexity, minlength and isPwned are checked on password setting (#18005) (#18015)
  * Fix rename notification bug (#18011)
  * Prevent double decoding of % in url params  (#17997) (#18001)
  * Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992)
  * Prevent deadlock in create issue (#17970) (#17982)
* TESTING
  * Use non-expiring key. (#17984) (#17985)

Signed-off-by: Andrew Thornton <[email protected]>

* Update CHANGELOG.md

Co-authored-by: 6543 <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Reset locale on login

Fix go-gitea#18020

Signed-off-by: Andrew Thornton <[email protected]>

* Update routers/web/user/auth.go

Co-authored-by: Gusted <[email protected]>

Co-authored-by: Gusted <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile language lost when browser is closed
6 participants